Fix RCTImageLoader to call completion handler when networking is unavailable#56255
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Fix RCTImageLoader to call completion handler when networking is unavailable#56255javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
…ailable Summary: `RCTImageLoader._loadURLRequest:` returned NULL without calling the completion handler when the `RCTNetworking` module was unavailable. This left `dispatch_group_wait` in `RCTSyncImageManager` blocking for the full 20-second timeout per image. Additionally, the checks were guarded by `RCT_DEBUG`, meaning they only ran in debug builds. Remove the `RCT_DEBUG` guard so the error path runs in all builds. Changelog: [Internal] Differential Revision: D98122553
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 7f7cc0a. |
Collaborator
|
This pull request was successfully merged by @javache in 7f7cc0a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTImageLoader._loadURLRequest:returned NULL without calling the completion handler when theRCTNetworkingmodule was unavailable. This leftdispatch_group_waitinRCTSyncImageManagerblocking for the full 20-second timeout per image.Additionally, the checks were guarded by
RCT_DEBUG, meaning they only ran in debug builds. Remove theRCT_DEBUGguard so the error path runs in all builds.Changelog: [Internal]
Differential Revision: D98122553